paleofetch

commit fd9f29ee659a30b4d8de913e7b7077cfad36ff22
parent 488294010da7d58a415225cf56eac31fb44f38d0
Author: Sridaran Thoniyil <sri7thon@gmail.com>
Date:   Fri,  8 May 2020 15:04:39 -0400

Get rid of the second buffer in battery function


Diffstat:
M
paleofetch.c
 | 
12
++++++------

1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/paleofetch.c b/paleofetch.c
@@ -236,24 +236,24 @@ static char *get_uptime() {
 // returns "<Battery Percentage>% [<Charging | Discharging | Unknown>]"
 static char *get_battery_percentage() {
     // battery status is at most 11 characters: "discharging"
-    char *battery_percentage = malloc(BUF_SIZE / 2), battery_status[12];
+    char *battery_percentage = malloc(BUF_SIZE / 2);
     FILE *battery_percentage_file, *battery_status_file;
 
     if((battery_percentage_file = fopen(BATTERY_DIRECTORY "/capacity", "r")) != NULL) {
         // at most 100, which is 3 characters
-        fread(battery_percentage, 1, 3, battery_percentage_file);
+        // read 4 so that the string is null or newline terminated even at 100
+        fread(battery_percentage, 1, 4, battery_percentage_file);
         int battery_percentage_length = remove_newline_get_length(battery_percentage);
         char* battery_percentage_end = battery_percentage + battery_percentage_length;
         strcat(battery_percentage_end, "% [");
         battery_percentage_end += 3;
         if((battery_status_file = fopen(BATTERY_DIRECTORY "/status", "r")) != NULL) {
-            fread(battery_status, 1, 12, battery_status_file);
-            int battery_status_length = remove_newline_get_length(battery_status);
-            strcat(battery_percentage_end, battery_status);
+            fread(battery_percentage_end, 1, 12, battery_status_file);
+            int battery_status_length = remove_newline_get_length(battery_percentage_end);
             strcat(battery_percentage_end + battery_status_length, "]");
         }
         else {
-            strcat(battery_percentage, "Unknown]");
+            strcat(battery_percentage_end, "Unknown]");
         }
 
         fclose(battery_status_file);