paleofetch

commit 61d9bffef0728817243ac4983bd24d8a40e94d87
parent 6eba61457e9e674d661fb0acb7e9d5397ac63d19
Author: dwzg <dennis@wtzg.de>
Date:   Fri,  1 May 2020 17:56:01 +0200

Add string length check in replace_substring()

Diffstat:
M
paleofetch.c
 | 
10
+++++++---

1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/paleofetch.c b/paleofetch.c
@@ -94,14 +94,18 @@ void remove_substring(char *str, const char* substring, size_t len) {
 /*
  * Replaces the first sub_len characters of sub_str from str
  * with the first repl_len characters of repl_str
- * This can be dangerous if repl_str is bigger than sub_str
- * as no checking is done if str is big enough
  */
 void replace_substring(char *str, const char *sub_str, const char *repl_str, size_t sub_len, size_t repl_len) {
-    char buffer[BUF_SIZE];
+    char buffer[BUF_SIZE / 2];
     char *start = strstr(str, sub_str);
     if (start == NULL) return; // substring not found
 
+    /* check if we have enough space for new substring */
+    if (strlen(str) - sub_len + repl_len >= BUF_SIZE / 2) {
+        status = -1;
+        halt_and_catch_fire("new substring too long to replace");
+    }
+
     strcpy(buffer, start + sub_len);
     strncpy(start, repl_str, repl_len);
     strcpy(start + repl_len, buffer);